Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1749143003: Add @overrides to (a lot of) analyzer. (Closed)

Created:
4 years, 9 months ago by pquitslund
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add @overrides to (a lot of) analyzer. This gets us roughly half+ way there. We should defintely consider automating this to speed up the rest. (Even with the quick-fix it's VERY tedious and slow going.) Once we've done this in bulk, I'd like to add the `annotate_overrides` lint to analyzer and server `.analysis_options`. BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9ea17184adbf00d4f14c4347e4f0cdc46a23885a

Patch Set 1 #

Patch Set 2 : options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -3 lines) Patch
M pkg/analyzer/.analysis_options View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/example/parser_driver.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/analyzer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 6 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 5 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/source/path_filter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/source.dart View 10 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 124 chunks +163 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/token.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/error.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_io.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/string_source.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
First come, first served. (You don't really BOTH need to review. :))
4 years, 9 months ago (2016-03-02 00:15:17 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-02 00:18:30 UTC) #3
Brian Wilkerson
LGTM, and yes, let's add the lint.
4 years, 9 months ago (2016-03-02 00:20:21 UTC) #4
pquitslund
Committed patchset #2 (id:20001) manually as 9ea17184adbf00d4f14c4347e4f0cdc46a23885a (presubmit successful).
4 years, 9 months ago (2016-03-02 00:33:27 UTC) #6
pquitslund
4 years, 9 months ago (2016-03-02 00:35:10 UTC) #7
Message was sent while issue was closed.
On 2016/03/02 00:20:21, Brian Wilkerson wrote:
> LGTM, and yes, let's add the lint.

Thanks.  Done.  Let's see how folks react and then talk about doing the same for
server.

Konstantin: maybe we should chat about writing a little bulk edit tool?

Powered by Google App Engine
This is Rietveld 408576698