Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1749103005: Revert of Use a bitmap to record PageMemoryRegion usage. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use a bitmap to record PageMemoryRegion usage. (patchset #1 id:1 of https://codereview.chromium.org/1748363005/ ) Reason for revert: Using a bitmap is problematic as pages within a region may belong to different threads (see https://crbug.com/591217 ). Revert back to previous and use a separate bool per thread to avoid overlap. Original issue's description: > Use a bitmap to record PageMemoryRegion usage. > > R=haraken > BUG=420515 > > Committed: https://crrev.com/648b0ff04620c688b1d8926b06220f45da3e4598 > Cr-Commit-Position: refs/heads/master@{#378449} TBR=oilpan-reviews@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://crrev.com/88336cbc14c314ee0b5d6c445ad2dca23ad5892a Cr-Commit-Position: refs/heads/master@{#378756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M third_party/WebKit/Source/platform/heap/PageMemory.h View 3 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Created Revert of Use a bitmap to record PageMemoryRegion usage.
4 years, 9 months ago (2016-03-02 16:03:26 UTC) #1
haraken
LGTM
4 years, 9 months ago (2016-03-02 16:03:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749103005/1
4 years, 9 months ago (2016-03-02 16:04:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 16:04:56 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 16:06:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88336cbc14c314ee0b5d6c445ad2dca23ad5892a
Cr-Commit-Position: refs/heads/master@{#378756}

Powered by Google App Engine
This is Rietveld 408576698