Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 17491007: Enable audio volume control on Android. (Closed)

Created:
7 years, 6 months ago by wjia(left Chromium)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Enable audio volume control on Android. This is done by setting stream to VOICE which is the only stream type hooking up volume control automatically. It's required to use matching audio mode and stream type. Otherwise, the volume control doesn't work. That means we have to use same mode for both WebAudio and WebRTC. This leads to the change in audio_manager_android.cc which sets audio to communication mode so that OpenSL stream can use VOICE stream type to adjust volume. Contributed by leozwang@chromium.org (original patch https://chromiumcodereview.appspot.com/12806009/) TBR=fischman@chromium.org BUG=222393, 243506 TEST=run https://apprtc.appspot.com/?debug=loopback on Google Android devices, e.g., Galaxy Nexus, Nexus4. The volume can be changed with the volume key. Also run some WebAudio test samples, e.g., https://developer.cdn.mozilla.net/media/uploads/demos/b/o/boblemarin/bf84de2482b5c2e1a869089fad3de56e/3eat5urfin9_1362006031_demo_package/index.html. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207921

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix webaudio #

Patch Set 4 : rebase and update description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -157 lines) Patch
M media/audio/android/audio_manager_android.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M media/audio/android/opensles_input.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/android/opensles_input.cc View 1 2 3 6 chunks +78 lines, -68 lines 0 comments Download
M media/audio/android/opensles_output.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/android/opensles_output.cc View 1 2 3 6 chunks +85 lines, -80 lines 0 comments Download
M media/audio/android/opensles_util.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
wjia(left Chromium)
Ami, PTAL. This CL is essentially same as https://chromiumcodereview.appspot.com/12806009/, except that the description is new.
7 years, 6 months ago (2013-06-20 20:43:17 UTC) #1
wjia(left Chromium)
7 years, 6 months ago (2013-06-21 21:16:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #4 manually as r207921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698