Fix a bug in graph construction for for loops.

tests/language/for_test.dart

Index: tests/language/for_test.dart
diff --git a/tests/language/for_test.dart b/tests/language/for_test.dart
index 8576acb602ef9848b6e4f0f3cfa2737ef4504ad9..96773998d0144803d76576db0cca8ceb1a579759 100644
--- a/tests/language/for_test.dart
+++ b/tests/language/for_test.dart
@@ -31,6 +31,20 @@ class Helper {
     }
     return i;
   }
+
+  static var status;
+  static void f5() {
+    status = 0;
+    for (var stop = false;;) {
+      if (stop) {
+        break;
+      } else {
+        stop = true;
+        continue;
+      }
+    }

[filemon, 2013/06/20 10:37:01]

Does this test fail before patching?

I mean, with the bug, the code in attachment (of issue below) always breaks from
loop, and status would be equal 1.

https://code.google.com/p/dart/issues/detail?id=11375

[Kevin Millikin (Google), 2013/06/20 10:48:45]

Yeah, it crashes without the fix.

We should really have exhaustive tests of all for loops:

* with and without initializer
* with and without test
* with and without update
* with and without normal exit from the body
* with and without break
* with and without continue

That's 64 possibilities.

[filemon, 2013/06/27 11:44:06]

Hi, I wrote a simple script to generate loops:
https://gist.github.com/orian/5875825

It needs some adjustment, what do you think?

On 2013/06/20 10:48:45, kmillikin wrote:

+    status = 1;
+  }
 }
 
 class ForTest {
@@ -50,6 +64,9 @@ class ForTest {
     Expect.equals(1, Helper.f4(1));
     Expect.equals(6, Helper.f4(6));
     Expect.equals(6, Helper.f4(10));
+
+    Helper.f5();
+    Expect.equals(1, Helper.status);
   }
 }