Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17491002: Revert r14930 and r14935 temporarily. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Revert r14930 and r14935 temporarily. This is a temporary revert to track down a potential perf regression introduced in r14930. The following two changes were reverted: - "Deprecate HAllocateObject in favor of HAllocate." - "Added pretenuring support for call new." R=danno@chromium.org BUG=chromium:247504 Committed: http://code.google.com/p/v8/source/detail?r=15229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -124 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap.cc View 3 chunks +14 lines, -3 lines 0 comments Download
M src/heap-inl.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +9 lines, -72 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +44 lines, -12 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +89 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-06-20 09:37:37 UTC) #1
danno
lgtm (rubber stamp)
7 years, 6 months ago (2013-06-20 10:46:19 UTC) #2
Michael Starzinger
7 years, 6 months ago (2013-06-20 10:48:32 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r15229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698