Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1749093002: Fix spec-compliance bug in ArrayIteratorPrototype. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix spec-compliance bug in ArrayIteratorPrototype. ArrayIteratorPrototype must not provide Symbol.iterator. R=rossberg BUG= Committed: https://crrev.com/85d1a55e83a0a424731a8175210a03489f0229ab Cr-Commit-Position: refs/heads/master@{#34386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/js/array-iterator.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 9 months ago (2016-03-01 10:54:46 UTC) #1
rossberg
lgtm
4 years, 9 months ago (2016-03-01 11:14:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749093002/1
4 years, 9 months ago (2016-03-01 11:30:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 11:50:48 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 11:51:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/85d1a55e83a0a424731a8175210a03489f0229ab
Cr-Commit-Position: refs/heads/master@{#34386}

Powered by Google App Engine
This is Rietveld 408576698