chrome/browser/memory/tab_manager.cc - Issue 1749073002: Do V8 GC ASAP if system memory is pressured

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory/tab_manager.cc

Issue 1749073002: Do V8 GC ASAP if system memory is pressured (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory/tab_manager.cc

diff --git a/chrome/browser/memory/tab_manager.cc b/chrome/browser/memory/tab_manager.cc

index a2299862de6deec44a10eb2a4db511c985a7d215..a0eec866e987318f8a353d5422433a879143ab48 100644

--- a/chrome/browser/memory/tab_manager.cc

+++ b/chrome/browser/memory/tab_manager.cc

@@ -206,7 +206,7 @@ void TabManager::Start() {

// Create a |MemoryPressureListener| to listen for memory events.

base::MemoryPressureMonitor* monitor = base::MemoryPressureMonitor::Get();

if (monitor) {

- memory_pressure_listener_.reset(new base::MemoryPressureListener(

+ memory_pressure_listener_.reset(base::MemoryPressureListener::Create(

base::Bind(&TabManager::OnMemoryPressure, base::Unretained(this))));

base::MemoryPressureListener::MemoryPressureLevel level =

monitor->GetCurrentPressureLevel();