base/memory/memory_pressure_monitor_chromeos_unittest.cc - Issue 1749073002: Do V8 GC ASAP if system memory is pressured

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/memory_pressure_monitor_chromeos_unittest.cc

Issue 1749073002: Do V8 GC ASAP if system memory is pressured (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/memory_pressure_monitor_chromeos_unittest.cc

diff --git a/base/memory/memory_pressure_monitor_chromeos_unittest.cc b/base/memory/memory_pressure_monitor_chromeos_unittest.cc

index 4333cd990e9f0d99bd721a19751d004b6a75122b..3bac2c535ec9c1ab1087d882fa95e24589d34baf 100644

--- a/base/memory/memory_pressure_monitor_chromeos_unittest.cc

+++ b/base/memory/memory_pressure_monitor_chromeos_unittest.cc

@@ -77,7 +77,7 @@ TEST(ChromeOSMemoryPressureMonitorTest, CheckMemoryPressure) {

std::unique_ptr<TestMemoryPressureMonitor> monitor(

new TestMemoryPressureMonitor);

std::unique_ptr<MemoryPressureListener> listener(

- new MemoryPressureListener(base::Bind(&OnMemoryPressure)));

+ MemoryPressureListener::Create(base::Bind(&OnMemoryPressure)));

// Checking the memory pressure while 0% are used should not produce any

// events.

monitor->SetMemoryInPercentOverride(0);