remoting/host/chromoting_lib.rc - Issue 1749053002: Move //remoting/remoting_host_win.gypi:* to GN

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/chromoting_lib.rc

Issue 1749053002: Move //remoting/remoting_host_win.gypi:* to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 1 typelib "remoting/host/chromoting_lib.tlb"
	Sergey Ulanov 2016/03/04 22:27:03 I think remoting/host/win would be more appropriat I think remoting/host/win would be more appropriate directory for this file because it's windows-specific. Also please add copyright header here, similar to what we have in core.rc.jinja2. Hzj_jie 2016/03/09 18:11:29 AFAIK, tlb is a type libraries generated automatic Show quoted text On 2016/03/04 22:27:03, Sergey Ulanov wrote: > I think remoting/host/win would be more appropriate directory for this file > because it's windows-specific. > Also please add copyright header here, similar to what we have in > core.rc.jinja2. AFAIK, tlb is a type libraries generated automatically by VC compiler, i.e. the file location depends on the source code. We cannot change it without moving source code to win also. Sergey Ulanov 2016/03/10 01:26:26 My comment was about this .rc file, not the .tlb f Show quoted text On 2016/03/09 18:11:29, Hzj_jie wrote: > On 2016/03/04 22:27:03, Sergey Ulanov wrote: > > I think remoting/host/win would be more appropriate directory for this file > > because it's windows-specific. > > Also please add copyright header here, similar to what we have in > > core.rc.jinja2. > > AFAIK, tlb is a type libraries generated automatically by VC compiler, i.e. the > file location depends on the source code. We cannot change it without moving > source code to win also. My comment was about this .rc file, not the .tlb file. Hzj_jie 2016/03/10 02:23:26 I see, my bad. Show quoted text On 2016/03/10 01:26:26, Sergey Ulanov wrote: > On 2016/03/09 18:11:29, Hzj_jie wrote: > > On 2016/03/04 22:27:03, Sergey Ulanov wrote: > > > I think remoting/host/win would be more appropriate directory for this file > > > because it's windows-specific. > > > Also please add copyright header here, similar to what we have in > > > core.rc.jinja2. > > > > AFAIK, tlb is a type libraries generated automatically by VC compiler, i.e. > the > > file location depends on the source code. We cannot change it without moving > > source code to win also. > > My comment was about this .rc file, not the .tlb file. I see, my bad.
OLD	NEW

« remoting/host/BUILD.gn ('K') | « remoting/host/BUILD.gn ('k') | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »