Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1749043002: [mojo-edk] Disable sync broker shared memory creation on Mac. (Closed)

Created:
4 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Disable sync broker shared memory creation on Mac. Mac-specific changes to ChannelPosix that track fds in transit, due to an OSX bug, conflict with the sync broker's message expectations. The best thing for now is to disable the sync broker usage on OSX. BUG=590979 Committed: https://crrev.com/1b2d1c9f119d12e861e202f39353cc5fb33f982a Cr-Commit-Position: refs/heads/master@{#378410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/edk/system/node_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Anand Mistry (off Chromium)
4 years, 9 months ago (2016-03-01 06:04:51 UTC) #2
Ken Rockot(use gerrit already)
lgtm - could you file a bug with more detail?
4 years, 9 months ago (2016-03-01 06:06:40 UTC) #3
Anand Mistry (off Chromium)
On 2016/03/01 06:06:40, Ken Rockot wrote: > lgtm - could you file a bug with ...
4 years, 9 months ago (2016-03-01 06:40:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749043002/1
4 years, 9 months ago (2016-03-01 06:41:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 07:15:07 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 07:16:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b2d1c9f119d12e861e202f39353cc5fb33f982a
Cr-Commit-Position: refs/heads/master@{#378410}

Powered by Google App Engine
This is Rietveld 408576698