Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1749033002: [for-in] Record slow path feedback only when we hit %ForInFilter. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[for-in] Record slow path feedback only when we hit %ForInFilter. The only place in fullcodegen, where we know for sure that a for-in loop entered the slow-path is right before the potential call to %ForInFilter. So there's no point in also updating the mode eagerly during ForInPrepare. R=yangguo@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/74d6c64cc00c1f1ef21338dfe007335c9c8bace2 Cr-Commit-Position: refs/heads/master@{#34377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -86 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-01 05:49:14 UTC) #1
Benedikt Meurer
Hey Yang, Simple cleanup, so fullcodegen will be consistent with what I'm porting to Ignition ...
4 years, 9 months ago (2016-03-01 05:50:14 UTC) #2
Yang
On 2016/03/01 05:50:14, Benedikt Meurer wrote: > Hey Yang, > > Simple cleanup, so fullcodegen ...
4 years, 9 months ago (2016-03-01 05:52:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749033002/1
4 years, 9 months ago (2016-03-01 05:53:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 06:09:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 06:10:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74d6c64cc00c1f1ef21338dfe007335c9c8bace2
Cr-Commit-Position: refs/heads/master@{#34377}

Powered by Google App Engine
This is Rietveld 408576698