third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js - Issue 1748993002: DevTools: Initial implementation of line-level CPU profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

Issue 1748993002: DevTools: Initial implementation of line-level CPU profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove JSSF to sdk dependency Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

index 21905ea09899de53128b7f43962dd247f100d1a5..c71b4597a403e312f9669c6209ea963463e1a7b6 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

@@ -1018,8 +1018,11 @@ WebInspector.TimelineModel.prototype = {

var cpuProfileEvent = events.peekLast();

if (cpuProfileEvent && cpuProfileEvent.name === WebInspector.TimelineModel.RecordType.CpuProfile) {

var cpuProfile = cpuProfileEvent.args["data"]["cpuProfile"];

- if (cpuProfile)

- jsSamples = WebInspector.TimelineJSProfileProcessor.generateTracingEventsFromCpuProfile(cpuProfile, thread);

+ if (cpuProfile) {

+ var jsProfileModel = new WebInspector.CPUProfileDataModel(cpuProfile);

+ WebInspector.TimelineJSProfileProcessor.buildLineLevelProfiles(jsProfileModel);

+ jsSamples = WebInspector.TimelineJSProfileProcessor.generateTracingEventsFromCpuProfile(jsProfileModel, thread);

+ }

}