DevTools: Initial implementation of line-level CPU profile.

third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 23 matching lines @@
 WebInspector.UISourceCodeFrame = function(uiSourceCode)
 {
     this._uiSourceCode = uiSourceCode;
     WebInspector.SourceFrame.call(this, this._uiSourceCode);
     this.textEditor.setAutocompleteDelegate(new WebInspector.SimpleAutocompleteDelegate());
     this._rowMessageBuckets = {};
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyChanged, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyCommitted, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.MessageAdded, this._onMessageAdded, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.MessageRemoved, this._onMessageRemoved, this);
+    this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.LineMarkerAdded, this._onLineMarkerAdded, this);
+    this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.LineMarkerRemoved, this._onLineMarkerRemoved, this);
     this._updateStyle();
 
     this._errorPopoverHelper = new WebInspector.PopoverHelper(this.element, this._getErrorAnchor.bind(this), this._showErrorPopover.bind(this));
     this._errorPopoverHelper.setTimeout(100, 100);
 }
 
 WebInspector.UISourceCodeFrame.prototype = {
     /**
      * @return {!WebInspector.UISourceCode}
      */
@@ skipping 57 matching lines @@
     },
 
     /**
      * @override
      */
     onTextEditorContentLoaded: function()
     {
         WebInspector.SourceFrame.prototype.onTextEditorContentLoaded.call(this);
         for (var message of this._uiSourceCode.messages())
             this._addMessageToSource(message);
+        this._populateLineMarkers();

[pfeldman, 2016/03/07 19:57:50]

_decorateLineMarkers?

[alph, 2016/03/08 00:57:43]

Done.

     },
 
     /**
      * @override
      * @param {!WebInspector.TextRange} oldRange
      * @param {!WebInspector.TextRange} newRange
      */
     onTextChanged: function(oldRange, newRange)
     {
         WebInspector.SourceFrame.prototype.onTextChanged.call(this, oldRange, newRange);
@@ skipping 192 matching lines @@
     },
 
     _updateBucketDecorations: function()
     {
         for (var line in this._rowMessageBuckets) {
             var bucket = this._rowMessageBuckets[line];
             bucket._updateDecoration();
         }
     },
 
+    /**
+     * @param {!WebInspector.Event} event
+     */
+    _onLineMarkerAdded: function(event)
+    {
+        var marker = /** @type {!WebInspector.UISourceCode.LineMarker} */ (event.data);
+        this._decorateLineMarker(marker);

[pfeldman, 2016/03/07 19:57:50]

Didn't you want to throttle these in a single CM operation?

[alph, 2016/03/08 00:57:42]

Done.

+    },
+
+    /**
+     * @param {!WebInspector.Event} event
+     */
+    _onLineMarkerRemoved: function(event)
+    {
+        var marker = /** @type {!WebInspector.UISourceCode.LineMarker} */ (event.data);
+        this._textEditor.setGutterMarker(marker.line(), marker.type(), null);
+    },
+
+    _populateLineMarkers: function()
+    {
+        for (var markers of this.uiSourceCode().lineMarkers().values())
+            markers.forEach(this._decorateLineMarker.bind(this));
+    },
+
+    _decorateLineMarker: function(marker)

[pfeldman, 2016/03/07 19:57:50]

JSDocs are missing.

[alph, 2016/03/08 00:57:43]

Done.

+    {
+        this._lineMarkerDecorator(marker.type()).then(decorator => this._textEditor.setGutterMarker(marker.line(), marker.type(), decorator.decorate(marker.data())));
+    },
+
+    _lineMarkerDecorator: function(type)

[pfeldman, 2016/03/07 19:57:50]

ditto

[alph, 2016/03/08 00:57:42]

Done.

+    {
+        return self.runtime.instancePromise("line-marker-decorator-" + type);

[pfeldman, 2016/03/07 19:57:50]

Decorator should be named after interface it implements.

[alph, 2016/03/08 00:57:42]

Done.

+    },
+
     __proto__: WebInspector.SourceFrame.prototype
 }
 
 WebInspector.UISourceCodeFrame._iconClassPerLevel = {};
 WebInspector.UISourceCodeFrame._iconClassPerLevel[WebInspector.UISourceCode.Message.Level.Error] = "error-icon";
 WebInspector.UISourceCodeFrame._iconClassPerLevel[WebInspector.UISourceCode.Message.Level.Warning] = "warning-icon";
 
 WebInspector.UISourceCodeFrame._lineClassPerLevel = {};
 WebInspector.UISourceCodeFrame._lineClassPerLevel[WebInspector.UISourceCode.Message.Level.Error] = "text-editor-line-with-error";
 WebInspector.UISourceCodeFrame._lineClassPerLevel[WebInspector.UISourceCode.Message.Level.Warning] = "text-editor-line-with-warning";
@@ skipping 204 matching lines @@
 
 /**
  * @param {!WebInspector.UISourceCode.Message} a
  * @param {!WebInspector.UISourceCode.Message} b
  * @return {number}
  */
 WebInspector.UISourceCode.Message.messageLevelComparator = function(a, b)
 {
     return WebInspector.UISourceCode.Message._messageLevelPriority[a.level()] - WebInspector.UISourceCode.Message._messageLevelPriority[b.level()];
 }