Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1748953004: [compiler] Fix a bunch of wrong word size assumptions. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Fix a bunch of wrong word size assumptions. Operations on word size data must be word sized, and not word32. Currently this only generates worse code, but in the future, it might even generate wrong code, so we should better get this right from the beginning. R=yangguo@chromium.org Committed: https://crrev.com/b4b9fc2927a98c0be4f6bd094a64884761b381d8 Cr-Commit-Position: refs/heads/master@{#34378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -107 lines) Patch
M src/compiler/code-stub-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 4 chunks +20 lines, -16 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 13 chunks +23 lines, -27 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 21 chunks +57 lines, -61 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-01 06:47:50 UTC) #1
Benedikt Meurer
Hey Yang, Bunch of bug fixes to make sure we use the correct machine operators ...
4 years, 9 months ago (2016-03-01 06:49:22 UTC) #2
Yang
On 2016/03/01 06:49:22, Benedikt Meurer wrote: > Hey Yang, > > Bunch of bug fixes ...
4 years, 9 months ago (2016-03-01 06:50:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748953004/1
4 years, 9 months ago (2016-03-01 06:50:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 07:08:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4b9fc2927a98c0be4f6bd094a64884761b381d8 Cr-Commit-Position: refs/heads/master@{#34378}
4 years, 9 months ago (2016-03-01 07:10:36 UTC) #8
rmcilroy
4 years, 9 months ago (2016-03-01 19:28:55 UTC) #9
Message was sent while issue was closed.
Thanks!

Random thought, is there any way we could run the code through a verification
phase before codegen to weed out invalid word size operations?

Powered by Google App Engine
This is Rietveld 408576698