runtime/vm/thread_pool.cc - Issue 1748953003: - Add assertions in MutexLocker/MonitorLocker to ensure that the code enclosed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_pool.cc

Issue 1748953003: - Add assertions in MutexLocker/MonitorLocker to ensure that the code enclosed (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code-review-comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/thread_pool.cc

diff --git a/runtime/vm/thread_pool.cc b/runtime/vm/thread_pool.cc

index 19c0a4d363a8ca1af052887c31e6c3e072e48860..b281d5c47fb6344392ca24a817418a2d6d9f216f 100644

--- a/runtime/vm/thread_pool.cc

+++ b/runtime/vm/thread_pool.cc

@@ -383,11 +383,11 @@ bool ThreadPool::Worker::Loop() {

task_ = NULL;

// Release monitor while handling the task.

- monitor_.Exit();

+ ml.Exit();

task->Run();

ASSERT(Isolate::Current() == NULL);

delete task;

- monitor_.Enter();

+ ml.Enter();

ASSERT(task_ == NULL);

if (IsDone()) {

« no previous file with comments | « runtime/vm/profiler.h ('k') | runtime/vm/thread_test.cc » ('j') | no next file with comments »