runtime/vm/port.cc - Issue 1748953003: - Add assertions in MutexLocker/MonitorLocker to ensure that the code enclosed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/port.cc

Issue 1748953003: - Add assertions in MutexLocker/MonitorLocker to ensure that the code enclosed (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code-review-comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/port.cc

diff --git a/runtime/vm/port.cc b/runtime/vm/port.cc

index 6af2ff82ca7be0f3db99951d71019d25f74b43dc..a57b93f302777fd2431f72f8ab91c0d2ac236b6d 100644

--- a/runtime/vm/port.cc

+++ b/runtime/vm/port.cc

@@ -313,7 +313,7 @@ void PortMap::PrintPortsForMessageHandler(MessageHandler* handler,

Object& msg_handler = Object::Handle();

{

JSONArray ports(&jsobj, "ports");

- MutexLocker ml(mutex_);

+ SafepointMutexLocker ml(mutex_);

for (intptr_t i = 0; i < capacity_; i++) {

if (map_[i].handler == handler) {

if (map_[i].state == kLivePort) {

« no previous file with comments | « runtime/vm/os_thread_win.cc ('k') | runtime/vm/profiler.h » ('j') | no next file with comments »