runtime/vm/os_thread.h - Issue 1748953003: - Add assertions in MutexLocker/MonitorLocker to ensure that the code enclosed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/os_thread.h

Issue 1748953003: - Add assertions in MutexLocker/MonitorLocker to ensure that the code enclosed (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code-review-comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/os_thread.h

diff --git a/runtime/vm/os_thread.h b/runtime/vm/os_thread.h

index ce22b2b0511d40ce1f84d95a987648f765508ab9..2ca6a7c8f4743912aa9790b8828506e8e6199bdc 100644

--- a/runtime/vm/os_thread.h

+++ b/runtime/vm/os_thread.h

@@ -267,7 +267,7 @@ class Mutex {

~Mutex();

void Lock();

- bool TryLock();

+ bool TryLock(); // Returns false if lock is busy and locking failed.

void Unlock();

#if defined(DEBUG)

@@ -303,6 +303,7 @@ class Monitor {

Monitor();

~Monitor();

+ bool TryEnter(); // Returns false if lock is busy and locking failed.

void Enter();

void Exit();

« no previous file with comments | « runtime/vm/message_handler.cc ('k') | runtime/vm/os_thread_android.cc » ('j') | no next file with comments »