Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 174893002: Remove handlers for user gesture callbacks (Closed)

Created:
6 years, 10 months ago by vabr (Chromium)
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Remove handlers for user gesture callbacks This reverts the CL https://codereview.chromium.org/82693006. That code was added as a support for password autofill value protection (Chromium part was https://codereview.chromium.org/83023017). That was recently refactored (https://codereview.chromium.org/163843002/) and does not need the Blink support any more. Precise identification of the revert, as generated by GIT: Revert "Adding handlers for user gesture callbacks. Whenever a UserGestureToken is created, calls all registered callbacks to alert them of gesture." This reverts commit b011272eda3e5193a5966522b9f845dd40fae1bd. BUG=337429, 163072 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -90 lines) Patch
M Source/platform/UserGestureIndicator.h View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/platform/UserGestureIndicator.cpp View 5 chunks +2 lines, -19 lines 0 comments Download
M Source/web/WebUserGestureIndicator.cpp View 2 chunks +0 lines, -34 lines 0 comments Download
M Source/web/tests/WebUserGestureTokenTest.cpp View 2 chunks +0 lines, -21 lines 0 comments Download
M public/web/WebUserGestureIndicator.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vabr (Chromium)
Hi Joel, Adam. I chose you two, as the author+reviewer of the https://codereview.chromium.org/82693006 being reverted. ...
6 years, 10 months ago (2014-02-21 08:50:38 UTC) #1
jww
On 2014/02/21 08:50:38, vabr (Chromium) wrote: > Hi Joel, Adam. > I chose you two, ...
6 years, 10 months ago (2014-02-21 21:32:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-24 09:49:26 UTC) #3
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 10 months ago (2014-02-24 09:53:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/174893002/1
6 years, 10 months ago (2014-02-24 09:54:02 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 12:31:23 UTC) #6
Message was sent while issue was closed.
Change committed as 167683

Powered by Google App Engine
This is Rietveld 408576698