src/objects.h - Issue 1748923003: [proxies] use [[GetPrototypeOf]] trap in for-in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1748923003: [proxies] use [[GetPrototypeOf]] trap in for-in (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: do not create a HandleScope when passing LookuptIterator* Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 53462cc7e08569b86e9aa66c22edc74b496a103b..615abbd20630a4acd3c8bf546554dcd0a599c388 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -1958,7 +1958,8 @@ class JSReceiver: public HeapObject {

// "for (n in object) { }".

MUST_USE_RESULT static MaybeHandle<FixedArray> GetKeys(

Handle<JSReceiver> object, KeyCollectionType type, PropertyFilter filter,

- GetKeysConversion keys_conversion = KEEP_NUMBERS);

+ GetKeysConversion keys_conversion = KEEP_NUMBERS,

+ bool filter_proxy_keys_ = true);

MUST_USE_RESULT static MaybeHandle<FixedArray> GetOwnValues(

Handle<JSReceiver> object, PropertyFilter filter);