Factor out code that looks up a canonical type and adds it to the canonical_types_ array if necessa…

Factor out code that looks up a canonical type and adds it to the canonical_types_ array if necessary.

BUG=
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/cd1112a382b2aabd73299e2fc593eefdd7b64cd3

[srdjan, 2016-02-29 23:07:32]

srdjan@google.com changed reviewers:
+ regis@google.com

[regis, 2016-02-29 23:40:05]

LGTM with a couple of comments.

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (left):

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc#ol...
runtime/vm/object.cc:15798: // grown the table, or may even have canonicalized
this type.
I would still keep this comment around, because the reason that we do a lookup
for the second time is not obvious.

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc#ol...
runtime/vm/object.cc:16308: // index, may have grown the table, or may even have
canonicalized this type.
ditto

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:4132: RawAbstractType* Class::LookupCanonicalType(const
AbstractType& lookup_type,
Lookup and insert?

[srdjan, 2016-02-29 23:49:10]

Description was changed from

==========
Factor out code that looks up a canonical type and adds it to the
canonical_types_ array if necessary.

BUG=
==========

to

==========
Factor out code that looks up a canonical type and adds it to the
canonical_types_ array if necessary.

BUG=
R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cd1112a382b2aabd73299e2fc593eefdd7b64cd3
==========

[srdjan, 2016-02-29 23:49:12]

Committed patchset #3 (id:40001) manually as
cd1112a382b2aabd73299e2fc593eefdd7b64cd3 (presubmit successful).

[srdjan, 2016-03-30 17:48:27]

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (left):

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc#ol...
runtime/vm/object.cc:15798: // grown the table, or may even have canonicalized
this type.
On 2016/02/29 23:40:04, regis wrote:
> I would still keep this comment around, because the reason that we do a lookup
> for the second time is not obvious.

Done.

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1748913002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:4132: RawAbstractType* Class::LookupCanonicalType(const
AbstractType& lookup_type,
On 2016/02/29 23:40:04, regis wrote:
> Lookup and insert?

LookupOrAdd