chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 174883003: mac: Disable CoreAnimation throbbers for now, while I investigate the performance regressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 174883003: mac: Disable CoreAnimation throbbers for now, while I investigate the performance regressions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

index 0c12eece09bea16e419c01c21e13e407407f6cd9..b84dc3a62295f2a9b906cb3c503fe0de4c3787a6 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

@@ -1611,8 +1611,10 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {

[[tabController mediaIndicatorView]

updateIndicator:TAB_MEDIA_STATE_NONE];

} else {

- iconView =

- [[[SpriteView alloc] initWithImage:throbberImage] autorelease];

+ NSRect frame =

+ NSMakeRect(0, 0, kIconWidthAndHeight, kIconWidthAndHeight);

+ iconView = [ThrobberView filmstripThrobberViewWithFrame:frame

+ image:throbberImage];

}

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tabs/throbber_view.h » ('j') | no next file with comments »