Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 174883002: Skip unreachable blocks when looking for next emitted block. (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Skip unreachable blocks when looking for next emitted block. Goto does not emit a jump if the target is the next emitted block. However, if there is an unreachable block between Goto and the jump target, we still emit a jump even though the unreachable block is not actually emitted. That jump is unnecessary. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/lithium-codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 10 months ago (2014-02-21 08:37:43 UTC) #1
Yang
On 2014/02/21 08:37:43, Yang wrote: ping
6 years, 9 months ago (2014-03-07 14:59:00 UTC) #2
Jakob Kummerow
LGTM. Sorry, this fell through the cracks.
6 years, 9 months ago (2014-03-07 18:15:22 UTC) #3
Yang
6 years, 9 months ago (2014-03-10 07:42:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698