Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1748803002: Remove fx_fpf.h and IWYU (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -24 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafont.h View 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fxge/android/fpf_skiafont.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M core/src/fxge/android/fpf_skiamodule.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M core/src/fxge/android/fx_android_font.h View 1 chunk +6 lines, -0 lines 0 comments Download
M core/src/fxge/android/fx_android_font.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M core/src/fxge/android/fx_android_imp.cpp View 2 chunks +8 lines, -1 line 0 comments Download
D core/src/fxge/android/fx_fpf.h View 1 chunk +0 lines, -15 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-02-29 21:47:41 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-02-29 22:00:57 UTC) #3
dsinclair
4 years, 9 months ago (2016-02-29 22:03:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ac4b8361e7919c6188587b89cbfbb748b3079b5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698