Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1748793002: Don't expand inline frames in noopt to match full precompiled behavior. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't expand inline frames in stacktraces under noopt to match full precompiled behavior. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/ad01f0fb41c8c3cc2df496a3f5781b6975d14bf0

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -98 lines) Patch
M runtime/tests/vm/vm.status View 1 3 chunks +9 lines, -13 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +14 lines, -53 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M tests/language/language.status View 3 chunks +13 lines, -28 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 9 months ago (2016-02-29 20:57:28 UTC) #2
Florian Schneider
lgtm
4 years, 9 months ago (2016-02-29 21:05:13 UTC) #3
rmacnak
4 years, 9 months ago (2016-02-29 21:28:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ad01f0fb41c8c3cc2df496a3f5781b6975d14bf0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698