Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6044)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 1748773002: Simplify the default browser infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fieldtrial testing Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 079500888e4ab790aed45b4402431f217494498a..9e5963659cf45362f0bfae8c313280485e640ed1 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -72,6 +72,7 @@
#include "components/dom_distiller/core/distilled_page_prefs.h"
#include "components/flags_ui/pref_service_flags_storage.h"
#include "components/gcm_driver/gcm_channel_status_syncer.h"
+#include "components/metrics/metrics_service.h"
#include "components/network_time/network_time_tracker.h"
#include "components/ntp_snippets/ntp_snippets_service.h"
#include "components/omnibox/browser/zero_suggest_provider.h"
@@ -279,6 +280,9 @@ const char kGoogleGeolocationAccessEnabled[] =
"googlegeolocationaccess.enabled";
#endif
+// Deprecated 4/2016.
+const char kCheckDefaultBrowser[] = "browser.check_default_browser";
+
} // namespace
namespace chrome {
@@ -592,6 +596,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
#if BUILDFLAG(ENABLE_GOOGLE_NOW)
registry->RegisterBooleanPref(kGoogleGeolocationAccessEnabled, false);
#endif
+
+ registry->RegisterBooleanPref(kCheckDefaultBrowser, true);
}
void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
@@ -673,6 +679,20 @@ void MigrateObsoleteProfilePrefs(Profile* profile) {
// Added 3/2016.
profile_prefs->ClearPref(kGoogleGeolocationAccessEnabled);
#endif
+
+ // Added 4/2016.
+ if (!profile_prefs->GetBoolean(kCheckDefaultBrowser)) {
+ // Seed kDefaultBrowserLastDeclined with the install date.
+ metrics::MetricsService* metrics_service =
+ g_browser_process->metrics_service();
+ base::Time install_time =
+ metrics_service
gab 2016/04/12 17:09:37 When would there ever not be a g_browser_process->
grt (UTC plus 2) 2016/04/12 17:12:46 I suppose so, but don't know for sure. I'm just fo
+ ? base::Time::FromTimeT(metrics_service->GetInstallDate())
+ : base::Time::Now();
+ profile_prefs->SetInt64(prefs::kDefaultBrowserLastDeclined,
+ install_time.ToInternalValue());
+ }
+ profile_prefs->ClearPref(kCheckDefaultBrowser);
}
} // namespace chrome
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698