components/nacl/browser/pnacl_translation_cache_unittest.cc - Issue 1748763003: Re-enable PnaclTranslationCacheTest.StoreLargeOnDisk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/pnacl_translation_cache_unittest.cc

Issue 1748763003: Re-enable PnaclTranslationCacheTest.StoreLargeOnDisk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/browser/pnacl_translation_cache_unittest.cc

diff --git a/components/nacl/browser/pnacl_translation_cache_unittest.cc b/components/nacl/browser/pnacl_translation_cache_unittest.cc

index e1b4125b81cd5cbabe27b7efec9fa08ac4f57be7..aaf7fa2ca52dd721698b939e9dad1b86fff0fbb1 100644

--- a/components/nacl/browser/pnacl_translation_cache_unittest.cc

+++ b/components/nacl/browser/pnacl_translation_cache_unittest.cc

@@ -226,11 +226,6 @@ TEST_F(PnaclTranslationCacheTest, StoreSmallOnDisk) {

}

TEST_F(PnaclTranslationCacheTest, StoreLargeOnDisk) {

-#if defined(OS_WIN)

- // Flaky on XP bot http://crbug.com/468741

- if (base::win::GetVersion() <= base::win::VERSION_XP)

- return;

-#endif

// Test a value too large(?) for a single I/O operation

InitBackend(false);

const std::string large_buffer(kLargeNexeSize, 'a');

« no previous file with comments | « no previous file | no next file » | no next file with comments »