Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1748763002: Move shouldFileBeAnalyzed into ContextManager (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -72 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 5 chunks +28 lines, -43 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 8 chunks +30 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 6 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-02-29 22:44:00 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-02-29 22:48:11 UTC) #3
Paul Berry
lgtm
4 years, 9 months ago (2016-03-01 17:18:36 UTC) #4
Brian Wilkerson
4 years, 9 months ago (2016-03-01 20:41:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
841f8e6cf23f97c90b634fd79832cec51098b1ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698