Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: ios/chrome/browser/browser_state/chrome_browser_state_io_data.h

Issue 1748673002: Remove isolated app code from iOS's chrome_browser_state_io_data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
diff --git a/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h b/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
index 837cf9b843c3cf6121c30ff1f054a0c62618f501..5f6ab62eb3f6942329bf522e0954b9ee864e4722 100644
--- a/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
+++ b/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
@@ -91,9 +91,6 @@ class ChromeBrowserStateIOData {
void Init(ProtocolHandlerMap* protocol_handlers) const;
net::URLRequestContext* GetMainRequestContext() const;
- net::URLRequestContext* GetIsolatedAppRequestContext(
- net::URLRequestContext* main_context,
- const base::FilePath& partition_path) const;
// These are useful when the Chrome layer is called from the content layer
// with a content::ResourceContext, and they want access to Chrome data for
@@ -136,25 +133,6 @@ class ChromeBrowserStateIOData {
}
protected:
- // A URLRequestContext for apps that owns its cookie store and HTTP factory,
- // to ensure they are deleted.
- class AppRequestContext : public net::URLRequestContext {
- public:
- AppRequestContext();
-
- void SetCookieStore(net::CookieStore* cookie_store);
- void SetHttpTransactionFactory(
- scoped_ptr<net::HttpTransactionFactory> http_factory);
- void SetJobFactory(scoped_ptr<net::URLRequestJobFactory> job_factory);
-
- private:
- ~AppRequestContext() override;
-
- scoped_refptr<net::CookieStore> cookie_store_;
- scoped_ptr<net::HttpTransactionFactory> http_factory_;
- scoped_ptr<net::URLRequestJobFactory> job_factory_;
- };
-
// Created on the UI thread, read on the IO thread during
// ChromeBrowserStateIOData lazy initialization.
struct ProfileParams {
@@ -249,16 +227,6 @@ class ChromeBrowserStateIOData {
ProfileParams* profile_params,
ProtocolHandlerMap* protocol_handlers) const = 0;
- // Does an on-demand initialization of a RequestContext for the given
- // isolated app.
- virtual net::URLRequestContext* InitializeAppRequestContext(
- net::URLRequestContext* main_context) const = 0;
-
- // These functions are used to transfer ownership of the lazily initialized
- // context from ChromeBrowserStateIOData to the URLRequestContextGetter.
- virtual net::URLRequestContext* AcquireIsolatedAppRequestContext(
- net::URLRequestContext* main_context) const = 0;
-
// The order *DOES* matter for the majority of these member variables, so
// don't move them around unless you know what you're doing!
// General rules:
@@ -307,8 +275,6 @@ class ChromeBrowserStateIOData {
// These are only valid in between LazyInitialize() and their accessor being
// called.
mutable scoped_ptr<net::URLRequestContext> main_request_context_;
- // One URLRequestContext per isolated app for main and media requests.
- mutable URLRequestContextMap app_request_context_map_;
mutable scoped_refptr<content_settings::CookieSettings> cookie_settings_;

Powered by Google App Engine
This is Rietveld 408576698