Implement KnownSuccessor method to some control instructions.

Implement KnownSuccessor method to some control instructions.

R=jkummerow@chromium.org
BUG=v8:3118
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=19759

[Jakob Kummerow, 2014-03-07 18:32:35]

LGTM with comments.

https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
src/hydrogen-instructions.cc:3142: }
I think you're missing a "return true;" here.

https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
src/hydrogen-instructions.h:3644: bool is_internalized_string_ : 1;  //
TODO(yangguo): make this part of HType.
I think we don't need this any more.

https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
src/hydrogen-instructions.h:4579: : HUnaryControlInstruction(value, NULL, NULL),
nit: indentation was correct before

https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
src/hydrogen-instructions.h:4583: bool compares_number_type_ : 1;
is this still used anywhere?

[Yang, 2014-03-10 14:47:13]

On 2014/03/07 18:32:35, Jakob wrote:
> LGTM with comments.
> 
>
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
> File src/hydrogen-instructions.cc (right):
> 
>
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
> src/hydrogen-instructions.cc:3142: }
> I think you're missing a "return true;" here.
> 
>
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.h
> File src/hydrogen-instructions.h (right):
> 
>
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
> src/hydrogen-instructions.h:3644: bool is_internalized_string_ : 1;  //
> TODO(yangguo): make this part of HType.
> I think we don't need this any more.
> 
>
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
> src/hydrogen-instructions.h:4579: : HUnaryControlInstruction(value, NULL,
NULL),
> nit: indentation was correct before
> 
>
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instruction...
> src/hydrogen-instructions.h:4583: bool compares_number_type_ : 1;
> is this still used anywhere?

Thanks for the review! Issues addressed and uploaded in a new patch set.

[Yang, 2014-03-10 14:50:09]

Committed patchset #3 manually as r19759 (presubmit successful).

[Jakob Kummerow, 2014-03-10 14:51:07]

https://codereview.chromium.org/174863002/diff/90001/src/hydrogen-instruction...
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/174863002/diff/90001/src/hydrogen-instruction...
src/hydrogen-instructions.cc:3149: return true;
I think this needs to be inside the if() {...} block.