Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1748613002: [turbofan] Unship try-catch. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unship try-catch. R=jkummerow@chromium.org Committed: https://crrev.com/c268aea4fbb74b03a788fba020705594d669efb8 Cr-Commit-Position: refs/heads/master@{#34358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-02-29 10:52:31 UTC) #1
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-02-29 10:53:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748613002/1
4 years, 9 months ago (2016-02-29 10:59:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 11:10:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c268aea4fbb74b03a788fba020705594d669efb8 Cr-Commit-Position: refs/heads/master@{#34358}
4 years, 9 months ago (2016-02-29 11:10:50 UTC) #7
Jarin
How about giving some reason for the revert? I am sure it would not be ...
4 years, 9 months ago (2016-03-08 08:02:02 UTC) #8
Jakob Kummerow
On 2016/03/08 08:02:02, Jarin wrote: > How about giving some reason for the revert? I ...
4 years, 9 months ago (2016-03-08 09:02:01 UTC) #9
Benedikt Meurer
4 years, 9 months ago (2016-03-08 09:17:28 UTC) #10
Message was sent while issue was closed.
The reason is that there are correctness issues with some lowerings, where we do
not properly handle the exception edges in every case. I fixed a few of them
some time ago, but there are probably more of them left, and we haven't had the
time to go through the lowerings before the release and add proper test cases
for everything.

Powered by Google App Engine
This is Rietveld 408576698