Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1748603002: [arm64] Make sure that memory allocated for assembler tests is executable. (Closed)

Created:
4 years, 9 months ago by baptiste.afsa1
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Make sure that memory allocated for assembler tests is executable. Fix some crashes when tests are run on real hardware. R=bmeurer@chromium.org Committed: https://crrev.com/c7339e6ee4c63b6fe5041d9073e67a951a788cbc Cr-Commit-Position: refs/heads/master@{#34355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M test/cctest/test-assembler-arm64.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
baptiste.afsa1
PTAL
4 years, 9 months ago (2016-02-29 10:25:48 UTC) #1
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-02-29 10:27:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748603002/1
4 years, 9 months ago (2016-02-29 10:32:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 10:51:35 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 10:52:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7339e6ee4c63b6fe5041d9073e67a951a788cbc
Cr-Commit-Position: refs/heads/master@{#34355}

Powered by Google App Engine
This is Rietveld 408576698