chrome/browser/engagement/site_engagement_helper.cc - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Addressing reviewer comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_request_limiter_unittest.cc ('k') | chrome/browser/engagement/site_engagement_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_helper.cc

diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc

index 089e47c03bd15457a5e85dbf5832958207e9e4ef..5fabdde8769790f14a179087c2a87ea6fb66d6b0 100644

--- a/chrome/browser/engagement/site_engagement_helper.cc

+++ b/chrome/browser/engagement/site_engagement_helper.cc

@@ -102,8 +102,8 @@ void SiteEngagementHelper::InputTracker::DidGetUserInteraction(

helper()->RecordUserInput(

SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE);

break;

- case blink::WebInputEvent::MouseWheel:

- helper()->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_WHEEL);

+ case blink::WebInputEvent::GestureScrollBegin:

+ helper()->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_SCROLL);

break;

case blink::WebInputEvent::Undefined:

// Explicitly ignore browser-initiated navigation input.