chrome/browser/download/download_request_limiter.cc - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_request_limiter.cc

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Addressing reviewer comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/download_request_limiter.cc

diff --git a/chrome/browser/download/download_request_limiter.cc b/chrome/browser/download/download_request_limiter.cc

index fbfded785e5e6e094267646358f3cc8b2ee12715..992e0a23958df40e84cc4a1a82b74e7722dcf358 100644

--- a/chrome/browser/download/download_request_limiter.cc

+++ b/chrome/browser/download/download_request_limiter.cc

@@ -99,7 +99,7 @@ void DownloadRequestLimiter::TabDownloadState::DidNavigateMainFrame(

void DownloadRequestLimiter::TabDownloadState::DidGetUserInteraction(

const blink::WebInputEvent::Type type) {

- if (is_showing_prompt() || type == blink::WebInputEvent::MouseWheel) {

+ if (is_showing_prompt() || type == blink::WebInputEvent::GestureScrollBegin) {

// Don't change state if a prompt is showing or if the user has scrolled.

return;

}

« no previous file with comments | « no previous file | chrome/browser/download/download_request_limiter_unittest.cc » ('j') | no next file with comments »