Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: chrome/browser/engagement/site_engagement_helper_unittest.cc

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture
Patch Set: Addressing reviewer comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/engagement/site_engagement_helper.h" 5 #include "chrome/browser/engagement/site_engagement_helper.h"
6 6
7 #include "base/test/histogram_tester.h" 7 #include "base/test/histogram_tester.h"
8 #include "base/timer/mock_timer.h" 8 #include "base/timer/mock_timer.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/engagement/site_engagement_service.h" 10 #include "chrome/browser/engagement/site_engagement_service.h"
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 }; 139 };
140 140
141 TEST_F(SiteEngagementHelperTest, KeyPressEngagementAccumulation) { 141 TEST_F(SiteEngagementHelperTest, KeyPressEngagementAccumulation) {
142 UserInputAccumulation(blink::WebInputEvent::RawKeyDown); 142 UserInputAccumulation(blink::WebInputEvent::RawKeyDown);
143 } 143 }
144 144
145 TEST_F(SiteEngagementHelperTest, MouseDownEventEngagementAccumulation) { 145 TEST_F(SiteEngagementHelperTest, MouseDownEventEngagementAccumulation) {
146 UserInputAccumulation(blink::WebInputEvent::MouseDown); 146 UserInputAccumulation(blink::WebInputEvent::MouseDown);
147 } 147 }
148 148
149 TEST_F(SiteEngagementHelperTest, MouseWheelEventEngagementAccumulation) { 149 TEST_F(SiteEngagementHelperTest, ScrollEventEngagementAccumulation) {
150 UserInputAccumulation(blink::WebInputEvent::MouseWheel); 150 UserInputAccumulation(blink::WebInputEvent::GestureScrollBegin);
151 } 151 }
152 152
153 TEST_F(SiteEngagementHelperTest, GestureEngagementAccumulation) { 153 TEST_F(SiteEngagementHelperTest, GestureEngagementAccumulation) {
154 UserInputAccumulation(blink::WebInputEvent::GestureTapDown); 154 UserInputAccumulation(blink::WebInputEvent::GestureTapDown);
155 } 155 }
156 156
157 TEST_F(SiteEngagementHelperTest, MediaEngagementAccumulation) { 157 TEST_F(SiteEngagementHelperTest, MediaEngagementAccumulation) {
158 GURL url1("https://www.google.com/"); 158 GURL url1("https://www.google.com/");
159 GURL url2("http://www.google.com/"); 159 GURL url2("http://www.google.com/");
160 content::WebContents* contents = web_contents(); 160 content::WebContents* contents = web_contents();
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 SiteEngagementMetrics::ENGAGEMENT_KEYPRESS, 2); 326 SiteEngagementMetrics::ENGAGEMENT_KEYPRESS, 2);
327 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram, 327 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
328 SiteEngagementMetrics::ENGAGEMENT_MOUSE, 1); 328 SiteEngagementMetrics::ENGAGEMENT_MOUSE, 1);
329 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram, 329 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
330 SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE, 330 SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE,
331 2); 331 2);
332 histograms.ExpectBucketCount( 332 histograms.ExpectBucketCount(
333 SiteEngagementMetrics::kEngagementTypeHistogram, 333 SiteEngagementMetrics::kEngagementTypeHistogram,
334 SiteEngagementMetrics::ENGAGEMENT_FIRST_DAILY_ENGAGEMENT, 1); 334 SiteEngagementMetrics::ENGAGEMENT_FIRST_DAILY_ENGAGEMENT, 1);
335 335
336 HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::MouseWheel); 336 HandleUserInputAndRestartTracking(helper,
337 blink::WebInputEvent::GestureScrollBegin);
337 HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::MouseDown); 338 HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::MouseDown);
338 HandleMediaPlaying(helper, true); 339 HandleMediaPlaying(helper, true);
339 HandleUserInputAndRestartTracking(helper, 340 HandleUserInputAndRestartTracking(helper,
340 blink::WebInputEvent::GestureTapDown); 341 blink::WebInputEvent::GestureTapDown);
341 HandleMediaPlaying(helper, false); 342 HandleMediaPlaying(helper, false);
342 343
343 EXPECT_DOUBLE_EQ(0.93, service->GetScore(url1)); 344 EXPECT_DOUBLE_EQ(0.93, service->GetScore(url1));
344 EXPECT_EQ(0, service->GetScore(url2)); 345 EXPECT_EQ(0, service->GetScore(url2));
345 histograms.ExpectTotalCount(SiteEngagementMetrics::kEngagementTypeHistogram, 346 histograms.ExpectTotalCount(SiteEngagementMetrics::kEngagementTypeHistogram,
346 12); 347 12);
347 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram, 348 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
348 SiteEngagementMetrics::ENGAGEMENT_MOUSE, 2); 349 SiteEngagementMetrics::ENGAGEMENT_MOUSE, 2);
349 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram, 350 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
350 SiteEngagementMetrics::ENGAGEMENT_WHEEL, 1); 351 SiteEngagementMetrics::ENGAGEMENT_SCROLL, 1);
351 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram, 352 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
352 SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE, 353 SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE,
353 3); 354 3);
354 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram, 355 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
355 SiteEngagementMetrics::ENGAGEMENT_MEDIA_VISIBLE, 356 SiteEngagementMetrics::ENGAGEMENT_MEDIA_VISIBLE,
356 1); 357 1);
357 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram, 358 histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
358 SiteEngagementMetrics::ENGAGEMENT_MEDIA_HIDDEN, 359 SiteEngagementMetrics::ENGAGEMENT_MEDIA_HIDDEN,
359 1); 360 1);
360 histograms.ExpectBucketCount( 361 histograms.ExpectBucketCount(
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 // When the timer fires, callbacks are added. 572 // When the timer fires, callbacks are added.
572 input_tracker_timer->Fire(); 573 input_tracker_timer->Fire();
573 EXPECT_FALSE(input_tracker_timer->IsRunning()); 574 EXPECT_FALSE(input_tracker_timer->IsRunning());
574 EXPECT_TRUE(IsTrackingInput(helper)); 575 EXPECT_TRUE(IsTrackingInput(helper));
575 576
576 // Navigation should start the initial delay timer again. 577 // Navigation should start the initial delay timer again.
577 Navigate(url1); 578 Navigate(url1);
578 EXPECT_TRUE(input_tracker_timer->IsRunning()); 579 EXPECT_TRUE(input_tracker_timer->IsRunning());
579 EXPECT_FALSE(IsTrackingInput(helper)); 580 EXPECT_FALSE(IsTrackingInput(helper));
580 } 581 }
OLDNEW
« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.cc ('k') | chrome/browser/engagement/site_engagement_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698