Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1748413002: dart2js cps: Reorder class definitions and run dartfmt. (Closed)

Created:
4 years, 9 months ago by asgerf
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Reorder class definitions and run dartfmt. Subclasses of Primitive and Expression have been grouped into separate sections of cps_ir_nodes.dart. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/396bf9ac15fd655e59f88eb848821a2a7dd59fec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+650 lines, -692 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 38 chunks +650 lines, -692 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 9 months ago (2016-03-01 14:22:27 UTC) #2
Kevin Millikin (Google)
lgtm
4 years, 9 months ago (2016-03-01 14:33:38 UTC) #3
asgerf
4 years, 9 months ago (2016-03-01 14:34:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
396bf9ac15fd655e59f88eb848821a2a7dd59fec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698