Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1748403005:
add a basic integration test for Flutter (Closed)
Descriptionadd a basic integration test for Flutter
BUG=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299060
Patch Set 1 #Patch Set 2 : remove accidental comments; make mac-only #Patch Set 3 : add TODO #Patch Set 4 : retrain the recipes #
Messages
Total messages: 32 (14 generated)
Description was changed from ========== add a basic integration test for Flutter BUG= ========== to ========== add a basic integration test for Flutter BUG= ==========
yjbanov@google.com changed reviewers: + abarth@google.com
lgtm
The CQ bit was checked by yjbanov@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748403005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748403005/60001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
eseidel@google.com changed reviewers: + eseidel@google.com
The CQ bit was checked by eseidel@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748403005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748403005/60001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
We need to figure out why it doesn't like abarth's lg.
I see. We need to get abarth added to project-infra-committers.
The CQ bit was checked by yjbanov@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748403005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748403005/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by eseidel@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748403005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748403005/60001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
eseidel@chromium.org changed reviewers: + eseidel@chromium.org
The CQ bit was checked by eseidel@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748403005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748403005/60001
Message was sent while issue was closed.
Description was changed from ========== add a basic integration test for Flutter BUG= ========== to ========== add a basic integration test for Flutter BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299060 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299060 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
