Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 17484010: Revert 207345 "[Android] Support building standalone APK in comp..." (Closed)

Created:
7 years, 6 months ago by Sami
Modified:
7 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 207345 "[Android] Support building standalone APK in comp..." This broke building of ChromeTest.apk. See: http://chromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/11555/steps/chrome_smoke_instrumentation_tests/logs/stdio > [Android] Support building standalone APK in component build > > Many people's workflows assume that they can install the APK created in > out/Debug/apks. With the component build that APK is actually an > "incomplete" APK that cannot be manually installed (or rather causes > obscure errors when manually installed). > > This change does two things. First, it moves the "incomplete" APK > output to out/Debug/<package_name>/<ApkName>.apk. This should prevent > accidental installs of the "incomplete" APK. Second, it introduces an > option (create_standalone_apk) that when doing a component build, if > set, will merge the shared libraries into the "incomplete" APK to > create a standalone APK. This standalone APK will be created in > out/Debug/apks/. > > Review URL: https://chromiumcodereview.appspot.com/14843017 TBR=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -205 lines) Patch
D trunk/src/build/android/create_standalone_apk_action.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
M trunk/src/build/android/developer_recommended_flags.gypi View 1 chunk +2 lines, -7 lines 0 comments Download
D trunk/src/build/android/finalize_apk_action.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
D trunk/src/build/android/gyp/create_standalone_apk.py View 1 chunk +0 lines, -61 lines 0 comments Download
M trunk/src/build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/build/java_apk.gypi View 7 chunks +27 lines, -49 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sami
7 years, 6 months ago (2013-06-20 15:29:33 UTC) #1
Sami
7 years, 6 months ago (2013-06-20 15:31:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r207439.

Powered by Google App Engine
This is Rietveld 408576698