Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1748383002: Fix more things with webgl so it works (Closed)

Created:
4 years, 9 months ago by terry
Modified:
4 years, 9 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@integration
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix more things with webgl so it works - dart.idl emitted currently supported operations in Chrome 45 so there were 9 duplicates. - Support mapping a bunch of webgl types to Dart types. TBR=jacobr@google.com,alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/3a6e6cafeaba585832933c3cab94928ea302ebaf Committed: https://github.com/dart-lang/sdk/commit/8cb5ef741f30ce2624ea5248d80772dc6b399090

Patch Set 1 #

Patch Set 2 : Moved fix from integration to Master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -41 lines) Patch
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -41 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
terry
Committed patchset #1 (id:1) manually as 3a6e6cafeaba585832933c3cab94928ea302ebaf (presubmit successful).
4 years, 9 months ago (2016-03-01 11:29:39 UTC) #2
terry
4 years, 9 months ago (2016-03-01 11:34:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8cb5ef741f30ce2624ea5248d80772dc6b399090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698