Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1748363005: Use a bitmap to record PageMemoryRegion usage. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a bitmap to record PageMemoryRegion usage. R=haraken BUG=420515 Committed: https://crrev.com/648b0ff04620c688b1d8926b06220f45da3e4598 Cr-Commit-Position: refs/heads/master@{#378449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M third_party/WebKit/Source/platform/heap/PageMemory.h View 3 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look.
4 years, 9 months ago (2016-03-01 15:32:11 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-01 15:36:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363005/1
4 years, 9 months ago (2016-03-01 15:54:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 16:28:50 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/648b0ff04620c688b1d8926b06220f45da3e4598 Cr-Commit-Position: refs/heads/master@{#378449}
4 years, 9 months ago (2016-03-01 16:31:03 UTC) #10
sof
4 years, 9 months ago (2016-03-02 16:03:26 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1749103005/ by sigbjornf@opera.com.

The reason for reverting is: Using a bitmap is problematic as pages within a
region may belong to different threads (see https://crbug.com/591217 ).

Revert back to previous and use a separate bool per thread to avoid overlap..

Powered by Google App Engine
This is Rietveld 408576698