Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1748363004:
Update DNG SDK version. (Closed)
DescriptionUpdate DNG SDK version.
* Integrate integer overflow changes from security branch
BUG=b/26535130
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004
Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567
Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754
Committed: https://skia.googlesource.com/skia/+/412f534563397fdda1229edffe6c49c15c5de59b
Patch Set 1 #Patch Set 2 : Use new version #Patch Set 3 : Use new DNG SDK version #Patch Set 4 : Use new version #Patch Set 5 : Use mew version #Messages
Total messages: 67 (34 generated)
Description was changed from ========== Update DNG SDK version. This version is only a change of line endings. It is a prestep of following work. BUG=skia: ========== to ========== Update DNG SDK version. This version is only a change of line endings. It is a prestep of following work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Update DNG SDK version. This version is only a change of line endings. It is a prestep of following work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update DNG SDK version. This version is only a change of line endings. It is a prestep of following work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
yujieqin@google.com changed reviewers: + msarett@google.com, scroggo@google.com
The CQ bit was checked by yujieqin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-03-01 18:42 UTC
Description was changed from ========== Update DNG SDK version. This version is only a change of line endings. It is a prestep of following work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by yujieqin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
lgtm
On 2016/03/01 12:54:11, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, > http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Hmm. We're using Visual Studio 2013 on windows, which does not support constexpr. (Although the Customer Technology Preview does. See http://stackoverflow.com/questions/20264644/constexpr-not-compiling-in-vc2013) Is there a reason for us to stick with the older version of Visual Studio? Or we can work around it by defining constexpr if it's not defined? (As const - it won't have the same benefit as constexpr; but unless they're truly relying on it being determinable at compile time that could work?) Or should we make changes in the DNG SDK to support compilers without constexpr?
On 2016/03/01 13:56:10, scroggo wrote: > On 2016/03/01 12:54:11, commit-bot: I haz the power wrote: > > Dry run: Try jobs failed on following builders: > > Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, > > > http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) > > Hmm. We're using Visual Studio 2013 on windows, which does not support > constexpr. (Although the Customer Technology Preview does. See > http://stackoverflow.com/questions/20264644/constexpr-not-compiling-in-vc2013) > > Is there a reason for us to stick with the older version of Visual Studio? Or we > can work around it by defining constexpr if it's not defined? (As const - it > won't have the same benefit as constexpr; but unless they're truly relying on it > being determinable at compile time that could work?) Or should we make changes > in the DNG SDK to support compilers without constexpr? We will fix the DNG SDK to avoid the usage of "constexpr" for now. I will update this CL as soon as we got that new version submitted to AOSP. Anyhow, I would be really happy to be able to use more new C++ features. :)
The CQ bit was checked by yujieqin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yujieqin@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com Link to the patchset: https://codereview.chromium.org/1748363004/#ps40001 (title: "Use new DNG SDK version")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/40001
Message was sent while issue was closed.
Description was changed from ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1755743003/ by yujieqin@google.com. The reason for reverting is: This breaks the ChromeOS build. E.g. https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x8....
Message was sent while issue was closed.
On 2016/03/02 12:07:21, yujieqin wrote: > A revert of this CL (patchset #3 id:40001) has been created in > https://codereview.chromium.org/1755743003/ by mailto:yujieqin@google.com. > > The reason for reverting is: This breaks the ChromeOS build. E.g. > https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x8.... Hi msarett, hi scroggo, it seems like we got a very strange issue for the ChromeOS build that the limit numbers from <cstdint> are not available. Do you folks know something about this?
Message was sent while issue was closed.
Description was changed from ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 ========== to ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 ==========
The CQ bit was checked by yujieqin@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com Link to the patchset: https://codereview.chromium.org/1748363004/#ps60001 (title: "Use new version")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/60001
Message was sent while issue was closed.
Description was changed from ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 ========== to ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1755283004/ by yujieqin@google.com. The reason for reverting is: Sorry for breaking the build again....
Message was sent while issue was closed.
Description was changed from ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754 ========== to ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754 ==========
The CQ bit was checked by yujieqin@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com Link to the patchset: https://codereview.chromium.org/1748363004/#ps80001 (title: "Use mew version")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748363004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748363004/80001
Message was sent while issue was closed.
Description was changed from ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754 ========== to ========== Update DNG SDK version. * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754 Committed: https://skia.googlesource.com/skia/+/412f534563397fdda1229edffe6c49c15c5de59b ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/412f534563397fdda1229edffe6c49c15c5de59b |
