Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1748343003: [debugger, interpreter] add break location at if-statement. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger, interpreter] add break location at if-statement. R=mstarzinger@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/21622ddae4cba7cec405136bbca9381a9a8308f7 Cr-Commit-Position: refs/heads/master@{#34394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +0 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Yang
4 years, 9 months ago (2016-03-01 13:01:29 UTC) #1
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-01 13:50:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748343003/1
4 years, 9 months ago (2016-03-01 13:51:29 UTC) #4
vogelheim
lgtm
4 years, 9 months ago (2016-03-01 13:56:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16292)
4 years, 9 months ago (2016-03-01 14:02:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748343003/1
4 years, 9 months ago (2016-03-01 14:03:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 14:25:58 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 14:26:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21622ddae4cba7cec405136bbca9381a9a8308f7
Cr-Commit-Position: refs/heads/master@{#34394}

Powered by Google App Engine
This is Rietveld 408576698