Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1748343002: Add include/ to include dir list for gcmole (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add include/ to include dir list for gcmole BUG= R=yangguo@chromium.org Committed: https://crrev.com/b576da405990359c062d6e736097293f03188ab8 Cr-Commit-Position: refs/heads/master@{#34381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gcmole/gcmole.lua View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-01 07:55:09 UTC) #1
Yang
On 2016/03/01 07:55:09, jochen wrote: lgtm.
4 years, 9 months ago (2016-03-01 07:55:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748343002/1
4 years, 9 months ago (2016-03-01 07:57:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 09:02:22 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 09:03:11 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b576da405990359c062d6e736097293f03188ab8
Cr-Commit-Position: refs/heads/master@{#34381}

Powered by Google App Engine
This is Rietveld 408576698