Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 174833002: Move UA style rulesets for <datalist> and input[type=color][list] to html.css (Closed)

Created:
6 years, 10 months ago by tkent
Modified:
6 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Visibility:
Public.

Description

Move UA style rulesets for <datalist> and input[type=color][list] to html.css Now all platforms suppor them by default. We don't need to use RenderTheme::extraDefaultStyleSheet. BUG=none TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167745

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M Source/core/css/html.css View 2 chunks +19 lines, -0 lines 2 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Keishi, would you review this please? https://codereview.chromium.org/174833002/diff/1/Source/core/css/html.css File Source/core/css/html.css (right): https://codereview.chromium.org/174833002/diff/1/Source/core/css/html.css#newcode826 Source/core/css/html.css:826: border-color: #000000; Why ...
6 years, 10 months ago (2014-02-21 07:33:39 UTC) #1
keishi
lgtm https://codereview.chromium.org/174833002/diff/1/Source/core/css/html.css File Source/core/css/html.css (right): https://codereview.chromium.org/174833002/diff/1/Source/core/css/html.css#newcode826 Source/core/css/html.css:826: border-color: #000000; On 2014/02/21 07:33:39, tkent wrote: > ...
6 years, 10 months ago (2014-02-25 01:37:01 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 10 months ago (2014-02-25 03:03:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/174833002/1
6 years, 10 months ago (2014-02-25 03:03:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/174833002/1
6 years, 10 months ago (2014-02-25 05:20:23 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 07:37:57 UTC) #6
Message was sent while issue was closed.
Change committed as 167745

Powered by Google App Engine
This is Rietveld 408576698