Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
174823003:
Blink roll 167621:167633 (Closed)
|
Created:
6 years, 10 months ago by eseidel Modified:
6 years, 10 months ago Reviewers:
CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionBlink roll 167621:167633
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167622:167633&mode=html
TBR=
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252815
Patch Set 1 #Messages
Total messages: 8 (0 generated)
The CQ bit was checked by eseidel@chromium.org
This roll was created by the Blink AutoRollBot.
http://www.chromium.org/blink/blinkrollbot
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/174823003/1
Message was sent while issue was closed.
Change committed as 252815
Message was sent while issue was closed.
+skobes I think http://src.chromium.org/viewvc/blink?revision=167627&view=revision caused chromiumos build failures. E.g.,: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd6... http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd6... chromeos-chrome-35.0.1855.0_alpha-r1: FAILED: x86_64-cros-linux-gnu-g++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.22-gold -MMD -MF obj/third_party/WebKit/Source/core/rendering/webcore_rendering.RenderTable.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1 -DUSE_XI2_MT=2 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_SVG_FONTS=1 -DENABLE_GDI_FONTS_ON_WINDOWS=0 -DENABLE_HARFBUZZ_ON_WINDOWS=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_SPEECH=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_LEGACY_NOTIFICATIONS=1 -DENABLE_MEDIA_CAPTURE=0 -DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DENABLE_OPENTYPE_VERTICAL=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG=1 -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source -I../../../../../../../home/chrome-bot/chrome_root/src -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit -Igen/blink -Igen/blink/bindings -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/angle/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ffmpeg -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/iccjpeg -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libpng -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libxml/linux/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libxml/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libxslt -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/npapi -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/npapi/bindings -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ots/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/qcms/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/sqlite -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/zlib -I../../../../../../../home/chrome-bot/chrome_root/src/v8/include -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -fno-strict-aliasing --sysroot=/build/amd64-generic/ -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -pipe -march=x86-64 -msse3 -D__google_stl_debug_vector=1 -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-c++0x-compat -c ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/RenderTable.cpp -o obj/third_party/WebKit/Source/core/rendering/webcore_rendering.RenderTable.o chromeos-chrome-35.0.1855.0_alpha-r1: In file included from ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/RenderTable.cpp:33:0: chromeos-chrome-35.0.1855.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/FastTextAutosizer.h: In member function 'virtual void WebCore::RenderTable::layout()': chromeos-chrome-35.0.1855.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/FastTextAutosizer.h:87:52: error: 'fastTextAutosizerLayoutScope.WebCore::FastTextAutosizer::LayoutScope::m_block' may be used uninitialized in this function [-Werror=maybe-uninitialized] chromeos-chrome-35.0.1855.0_alpha-r1: m_textAutosizer->endLayout(m_block); chromeos-chrome-35.0.1855.0_alpha-r1: ^ chromeos-chrome-35.0.1855.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/RenderTable.cpp:417:36: note: 'fastTextAutosizerLayoutScope.WebCore::FastTextAutosizer::LayoutScope::m_block' was declared here chromeos-chrome-35.0.1855.0_alpha-r1: FastTextAutosizer::LayoutScope fastTextAutosizerLayoutScope(document(), this); chromeos-chrome-35.0.1855.0_alpha-r1: ^ chromeos-chrome-35.0.1855.0_alpha-r1: cc1plus: all warnings being treated as errors
Message was sent while issue was closed.
On 2014/02/22 22:23:50, viettrungluu wrote: > +skobes > > I think > > http://src.chromium.org/viewvc/blink?revision=167627&view=revision > > caused chromiumos build failures. E.g.,: > > http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%2520%2528... > http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%2520%2528... > > chromeos-chrome-35.0.1855.0_alpha-r1: FAILED: x86_64-cros-linux-gnu-g++ > -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.22-gold -MMD -MF > obj/third_party/WebKit/Source/core/rendering/webcore_rendering.RenderTable.o.d > -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD > -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 > -DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 > -DUSE_X11=1 -DOS_CHROMEOS=1 -DUSE_XI2_MT=2 -DIMAGE_LOADER_EXTENSION=1 > -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS > -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS > -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 > -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 > -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 > -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 > -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 > -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 > -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK > -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_SVG_FONTS=1 > -DENABLE_GDI_FONTS_ON_WINDOWS=0 -DENABLE_HARFBUZZ_ON_WINDOWS=1 > -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_SPEECH=1 > -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_LEGACY_NOTIFICATIONS=1 > -DENABLE_MEDIA_CAPTURE=0 -DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 > -DENABLE_OPENTYPE_VERTICAL=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 > -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DSK_ENABLE_INST_COUNT=0 > -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' > -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 > -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG=1 > -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 > -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_USE_POSIX_THREADS > -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DCHROME_PNG_WRITE_SUPPORT > -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -D__STDC_CONSTANT_MACROS > -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 > -D_FORTIFY_SOURCE=2 > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source > -I../../../../../../../home/chrome-bot/chrome_root/src > -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos > -I../../../../../../../home/chrome-bot/chrome_root/src/gpu > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit > -Igen/blink -Igen/blink/bindings > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/angle/include > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ffmpeg > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/core > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils > -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/iccjpeg > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libpng > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libxml/linux/include > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libxml/src/include > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libxslt > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/npapi > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/npapi/bindings > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ots/include > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/qcms/src > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/sqlite > -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/zlib > -I../../../../../../../home/chrome-bot/chrome_root/src/v8/include -Werror > -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter > -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC > -Wno-unused-local-typedefs -fno-strict-aliasing --sysroot=/build/amd64-generic/ > -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -pipe > -march=x86-64 -msse3 -D__google_stl_debug_vector=1 -fno-rtti > -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare > -Wno-c++0x-compat -c > ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/RenderTable.cpp > -o obj/third_party/WebKit/Source/core/rendering/webcore_rendering.RenderTable.o > chromeos-chrome-35.0.1855.0_alpha-r1: In file included from > ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/RenderTable.cpp:33:0: > chromeos-chrome-35.0.1855.0_alpha-r1: > ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/FastTextAutosizer.h: > In member function 'virtual void WebCore::RenderTable::layout()': > chromeos-chrome-35.0.1855.0_alpha-r1: > ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/FastTextAutosizer.h:87:52: > error: > 'fastTextAutosizerLayoutScope.WebCore::FastTextAutosizer::LayoutScope::m_block' > may be used uninitialized in this function [-Werror=maybe-uninitialized] > chromeos-chrome-35.0.1855.0_alpha-r1: > m_textAutosizer->endLayout(m_block); > chromeos-chrome-35.0.1855.0_alpha-r1: > ^ > chromeos-chrome-35.0.1855.0_alpha-r1: > ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/rendering/RenderTable.cpp:417:36: > note: > 'fastTextAutosizerLayoutScope.WebCore::FastTextAutosizer::LayoutScope::m_block' > was declared here > chromeos-chrome-35.0.1855.0_alpha-r1: FastTextAutosizer::LayoutScope > fastTextAutosizerLayoutScope(document(), this); > chromeos-chrome-35.0.1855.0_alpha-r1: ^ > chromeos-chrome-35.0.1855.0_alpha-r1: cc1plus: all warnings being treated as > errors I think I see the error. Patch coming right up
Message was sent while issue was closed.
This has been fixed on trunk: https://codereview.chromium.org/176433002
Message was sent while issue was closed.
On 2014/02/22 22:52:08, pdr wrote: > This has been fixed on trunk: https://codereview.chromium.org/176433002 Philip, thanks for fixing this. I wonder why the CQ didn't catch it? |
