Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1748203002: Add data to blink_platform_unittests.isolate (Closed)

Created:
4 years, 9 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add data to blink_platform_unittests.isolate The blink_platform_unittests target is failing on the "Android Tests (trial)(dbg)" bot and some of the failures suggest that it is due to files not being available on the device. This patch adds an include and a data path to the blink_platform_unittests.isolate file, as used in webkit_unit_tests.isolate, to address this. BUG=590888 Committed: https://crrev.com/0d486bcc84474c58e5060fe8bc1349f52e690717 Cr-Commit-Position: refs/heads/master@{#378655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/blink_platform_unittests.isolate View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
suzyh_UTC10 (ex-contributor)
Hi Dirk, jbroman suggested that the blink_platform_unittests failures may be in part due to missing ...
4 years, 9 months ago (2016-03-01 00:35:13 UTC) #2
Dirk Pranke
lgtm. I don't think there is a great way to test this other than locally ...
4 years, 9 months ago (2016-03-01 18:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748203002/1
4 years, 9 months ago (2016-03-01 23:27:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 02:08:23 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 02:09:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d486bcc84474c58e5060fe8bc1349f52e690717
Cr-Commit-Position: refs/heads/master@{#378655}

Powered by Google App Engine
This is Rietveld 408576698