Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 17482007: Reland: cros: Show notification when low-power charger connected (Closed)

Created:
7 years, 6 months ago by James Cook
Modified:
7 years, 6 months ago
Reviewers:
CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Reland: cros: Show notification when low-power charger connected First landed as https://codereview.chromium.org/17157007 and broke win_aura Encourage the user to plug in the official charger. Also extract FakeMessageCenter into a message_center_test_support target so I can use it for a unit test. BUG=249852 TEST=ash_unittests TrayPowerTest.* TBR=mukai@chromium.org - previously reviewed Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207584

Patch Set 1 #

Patch Set 2 : remove export macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -17 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/ash_chromeos_strings.grdp View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/ash_switches.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/ash_switches.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M ash/system/chromeos/power/tray_power.h View 5 chunks +34 lines, -8 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 6 chunks +56 lines, -3 lines 0 comments Download
A ash/system/chromeos/power/tray_power_unittest.cc View 1 chunk +152 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M ui/message_center/message_center.gyp View 3 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/17482007/2001
7 years, 6 months ago (2013-06-20 18:36:35 UTC) #1
James Cook
Verified that a Windows Aura shared-library build works locally.
7 years, 6 months ago (2013-06-20 18:38:38 UTC) #2
James Cook
Green try runs, but CQ seems stuck waiting on android_dbg_triggered_tests - dcommit-ing
7 years, 6 months ago (2013-06-20 21:28:26 UTC) #3
James Cook
7 years, 6 months ago (2013-06-20 21:37:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r207584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698