Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1748183007: Remove dependency on SkJsonCanvas.h (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M gyp/skiaserve.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/debugger/SkDrawCommand.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/skiaserve/Request.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
joshualitt
ptal, kind of not sure how this is building for any of us
4 years, 9 months ago (2016-03-03 19:30:32 UTC) #3
ethannicholas
On 2016/03/03 19:30:32, joshualitt wrote: > ptal, kind of not sure how this is building ...
4 years, 9 months ago (2016-03-03 19:31:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748183007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748183007/1
4 years, 9 months ago (2016-03-03 19:32:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748183007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748183007/1
4 years, 9 months ago (2016-03-03 19:38:23 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 19:39:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bd72413059d913ceddbf5cd29327c05b13a62503

Powered by Google App Engine
This is Rietveld 408576698