[sqlite] Remove recover.c from amalgamation.

[sqlite] Remove recover.c from amalgamation.

Build recover.c as a separate object file from SQLite core.  Preparing
for building it with system SQLite for systems which don't use
Chromium's SQLite.

BUG=584407
Committed: https://crrev.com/ce1818cc897f79189865e3a5daf022abf54e8aae
Cr-Commit-Position: refs/heads/master@{#379954}

[Scott Hess - ex-Googler, 2016-03-01 23:48:56]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 23:49:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183004/1

[Scott Hess - ex-Googler, 2016-03-02 01:17:37]

Annotating for reviewer.

https://codereview.chromium.org/1748183004/diff/1/sql/recovery.cc
File sql/recovery.cc (right):

https://codereview.chromium.org/1748183004/diff/1/sql/recovery.cc#newcode19
sql/recovery.cc:19: #include "third_party/sqlite/src/src/recover.h"
I originally had third_party/sqlite/sqlite3.h include recover.h, but I found
that on Linux it just didn't work.  I don't know why.  I'd prefer to circle back
around after landing the series, because I also found I couldn't really test
USE_SYSTEM_SQLITE on Linux (possibly because of sysroot?).

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/amalgama...
File third_party/sqlite/amalgamation/sqlite3.c (left):

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/amalgama...
third_party/sqlite/amalgamation/sqlite3.c:7643: -
This file is generated by a script, and includes changes from sqlite/src/src
files such as recover.c and sqlite.h.in.  Thus not really important to review.

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/amalgama...
File third_party/sqlite/amalgamation/sqlite3.h (left):

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/amalgama...
third_party/sqlite/amalgamation/sqlite3.h:7428: /* End recover virtual table
patch for Chromium */
Moved to recover.h.

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/src/Make...
File third_party/sqlite/src/Makefile.in (left):

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/src/Make...
third_party/sqlite/src/Makefile.in:264: $(TOP)/src/recover_varint.c \
This change removes the recover code from the amalgamation, so for
SQLite-internal testing purposes, I only need it in testfixture.

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/src/src/...
File third_party/sqlite/src/src/recover.h (right):

https://codereview.chromium.org/1748183004/diff/1/third_party/sqlite/src/src/...
third_party/sqlite/src/src/recover.h:18: SQLITE_API
CHROMIUM_SQLITE_API was a hack because of how SQLite uses scripts to build the
amalgamation.  Now SQLITE_API can be used directly.  It is necessary to allow
the module to be compiled either as part of a shlib or as part of a regular
library.

[commit-bot: I haz the power, 2016-03-02 02:03:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 02:03:19]

Dry run: This issue passed the CQ dry run.

[Scott Hess - ex-Googler, 2016-03-02 18:44:17]

shess@chromium.org changed reviewers:
+ sdefresne@chromium.org

[Scott Hess - ex-Googler, 2016-03-02 18:44:18]

Thanks for volunteering!  Let me know if you have questions.

[sdefresne, 2016-03-08 15:47:44]

lgtm

[Scott Hess - ex-Googler, 2016-03-08 21:23:01]

Rebase

[Scott Hess - ex-Googler, 2016-03-08 21:23:34]

The CQ bit was checked by shess@chromium.org

[Scott Hess - ex-Googler, 2016-03-08 21:23:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1748183004/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-08 21:24:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183004/20001

[commit-bot: I haz the power, 2016-03-08 23:03:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-08 23:04:42]

Description was changed from

==========
[sqlite] Remove recover.c from amalgamation.

Build recover.c as a separate object file from SQLite core.  Preparing
for building it with system SQLite for systems which don't use
Chromium's SQLite.

BUG=584407
==========

to

==========
[sqlite] Remove recover.c from amalgamation.

Build recover.c as a separate object file from SQLite core.  Preparing
for building it with system SQLite for systems which don't use
Chromium's SQLite.

BUG=584407

Committed: https://crrev.com/ce1818cc897f79189865e3a5daf022abf54e8aae
Cr-Commit-Position: refs/heads/master@{#379954}
==========

[commit-bot: I haz the power, 2016-03-08 23:04:43]

Patchset 2 (id:??) landed as
https://crrev.com/ce1818cc897f79189865e3a5daf022abf54e8aae
Cr-Commit-Position: refs/heads/master@{#379954}

[Scott Hess - ex-Googler, 2016-03-09 06:33:16]

https://codereview.chromium.org/1748183004/diff/1/sql/recovery.cc
File sql/recovery.cc (right):

https://codereview.chromium.org/1748183004/diff/1/sql/recovery.cc#newcode19
sql/recovery.cc:19: #include "third_party/sqlite/src/src/recover.h"
On 2016/03/02 01:17:37, Scott Hess wrote:
> I originally had third_party/sqlite/sqlite3.h include recover.h, but I found
> that on Linux it just didn't work.  I don't know why.  I'd prefer to circle
back
> around after landing the series, because I also found I couldn't really test
> USE_SYSTEM_SQLITE on Linux (possibly because of sysroot?).

Looks like I get to figure it out now, since other includes of this sort broke
the build (but not the commit queue) when landing
https://codereview.chromium.org/1757653002/ ...