Make RUNTIME_ASSERT have more useful output in debug mode

Make RUNTIME_ASSERT have more useful output in debug mode

Runtime asserts are were previously a bit annoying to debug, due to
the lack of a useful error message, even in debug mode. This patch
prints out some more information in debug mode for runtime assert
failures while preserving their exception-throwing semantics. While
we're at it, it requires a semicolon after RUNTIME_ASSERT macro
invocations.

```
$ rlwrap out/Debug/d8 --allow-natives-syntax
V8 version 5.1.0 (candidate)
d8> %ArrayBufferNeuter(1)

#
# Runtime error in ../../src/runtime/runtime-typedarray.cc, line 52
#
# args[0]->IsJSArrayBuffer()

==== C stack trace ===============================

 1: 0xf70ab5
 2: 0xadeebf
 3: 0xadedd4
 4: 0x2ef17630693b
(d8):1: illegal access
%ArrayBufferNeuter(1)
^

d8>
```

Also give the other 'illegal access' case (a special SyntaxError type) a more
descriptive error message for its sole usage.

R=adamk

Committed: https://crrev.com/78d845308fd89e2acdeb95ab01a20042794f04f1
Cr-Commit-Position: refs/heads/master@{#34401}

[Dan Ehrenberg, 2016-03-01 00:03:07]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 00:03:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183002/1

[Dan Ehrenberg, 2016-03-01 00:03:45]

Description was changed from

==========
Make RUNTIME_ASSERT have more useful output in debug mode

Runtime asserts are were previously a bit annoying to debug, due to
the lack of a useful error message, even in debug mode. This patch
prints out some more information in debug mode for runtime assert
failures while preserving their exception-throwing semantics. While
we're at it, it requires a semicolon after RUNTIME_ASSERT macro
invocations.

```
$ rlwrap out/Debug/d8 --allow-natives-syntax
V8 version 5.1.0 (candidate)
d8> %ArrayBufferNeuter(1)

==== C stack trace ===============================

 1: 0xf70ab5
 2: 0xadeebf
 3: 0xadedd4
 4: 0x2ef17630693b
(d8):1: illegal access
%ArrayBufferNeuter(1)
^

d8>
```

R=adamk
==========

to

==========
Make RUNTIME_ASSERT have more useful output in debug mode

Runtime asserts are were previously a bit annoying to debug, due to
the lack of a useful error message, even in debug mode. This patch
prints out some more information in debug mode for runtime assert
failures while preserving their exception-throwing semantics. While
we're at it, it requires a semicolon after RUNTIME_ASSERT macro
invocations.

```
$ rlwrap out/Debug/d8 --allow-natives-syntax
V8 version 5.1.0 (candidate)
d8> %ArrayBufferNeuter(1)

#
# Runtime error in ../../src/runtime/runtime-typedarray.cc, line 52
#
# args[0]->IsJSArrayBuffer()   

==== C stack trace ===============================

 1: 0xf70ab5
 2: 0xadeebf
 3: 0xadedd4
 4: 0x2ef17630693b
(d8):1: illegal access
%ArrayBufferNeuter(1)
^

d8>
```

R=adamk
==========

[commit-bot: I haz the power, 2016-03-01 00:06:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 00:06:31]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11665)

[Dan Ehrenberg, 2016-03-01 00:13:52]

Description was changed from

==========
Make RUNTIME_ASSERT have more useful output in debug mode

Runtime asserts are were previously a bit annoying to debug, due to
the lack of a useful error message, even in debug mode. This patch
prints out some more information in debug mode for runtime assert
failures while preserving their exception-throwing semantics. While
we're at it, it requires a semicolon after RUNTIME_ASSERT macro
invocations.

```
$ rlwrap out/Debug/d8 --allow-natives-syntax
V8 version 5.1.0 (candidate)
d8> %ArrayBufferNeuter(1)

#
# Runtime error in ../../src/runtime/runtime-typedarray.cc, line 52
#
# args[0]->IsJSArrayBuffer()   

==== C stack trace ===============================

 1: 0xf70ab5
 2: 0xadeebf
 3: 0xadedd4
 4: 0x2ef17630693b
(d8):1: illegal access
%ArrayBufferNeuter(1)
^

d8>
```

R=adamk
==========

to

==========
Make RUNTIME_ASSERT have more useful output in debug mode

Runtime asserts are were previously a bit annoying to debug, due to
the lack of a useful error message, even in debug mode. This patch
prints out some more information in debug mode for runtime assert
failures while preserving their exception-throwing semantics. While
we're at it, it requires a semicolon after RUNTIME_ASSERT macro
invocations.

```
$ rlwrap out/Debug/d8 --allow-natives-syntax
V8 version 5.1.0 (candidate)
d8> %ArrayBufferNeuter(1)

#
# Runtime error in ../../src/runtime/runtime-typedarray.cc, line 52
#
# args[0]->IsJSArrayBuffer()   

==== C stack trace ===============================

 1: 0xf70ab5
 2: 0xadeebf
 3: 0xadedd4
 4: 0x2ef17630693b
(d8):1: illegal access
%ArrayBufferNeuter(1)
^

d8>
```

Also give the other 'illegal access' case (a special SyntaxError type) a more
descriptive error message for its sole usage.

R=adamk
==========

[Dan Ehrenberg, 2016-03-01 00:18:08]

littledan@chromium.org changed reviewers:
+ jochen@chromium.org

[Dan Ehrenberg, 2016-03-01 00:18:22]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 00:18:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183002/20001

[commit-bot: I haz the power, 2016-03-01 00:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 00:48:47]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-03-01 02:32:32]

adamk@chromium.org changed reviewers:
+ verwaest@chromium.org

[adamk, 2016-03-01 02:32:33]

This change lgtm, but you'll need jochen for base/OWNERS, but is there a reason
a particular reason to put V8_RuntimeError in base?

Also adding verwaest@ in case he has any thoughts.

[Dan Ehrenberg, 2016-03-01 06:20:33]

On 2016/03/01 at 02:32:33, adamk wrote:
> This change lgtm, but you'll need jochen for base/OWNERS, but is there a
reason a particular reason to put V8_RuntimeError in base?
> 
> Also adding verwaest@ in case he has any thoughts.

I put it in there since I thought it made sense to put similar code in similar
places (a change to one should probably change the other, or maybe I should
refactor it to share the code), and I didn't want to choose the location based
on OWNERS. Thanks for adding people.

[jochen (gone - plz use gerrit), 2016-03-01 14:43:54]

lgtm

[Dan Ehrenberg, 2016-03-01 16:39:58]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 16:40:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183002/20001

[commit-bot: I haz the power, 2016-03-01 16:42:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 16:42:15]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-03-01 16:50:49]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 16:50:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183002/20001

[commit-bot: I haz the power, 2016-03-01 16:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 16:53:16]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-03-01 17:07:13]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 17:07:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183002/20001

[commit-bot: I haz the power, 2016-03-01 17:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 17:09:12]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-03-01 17:18:47]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-01 17:18:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748183002/20001

[commit-bot: I haz the power, 2016-03-01 17:21:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 17:22:35]

Description was changed from

==========
Make RUNTIME_ASSERT have more useful output in debug mode

Runtime asserts are were previously a bit annoying to debug, due to
the lack of a useful error message, even in debug mode. This patch
prints out some more information in debug mode for runtime assert
failures while preserving their exception-throwing semantics. While
we're at it, it requires a semicolon after RUNTIME_ASSERT macro
invocations.

```
$ rlwrap out/Debug/d8 --allow-natives-syntax
V8 version 5.1.0 (candidate)
d8> %ArrayBufferNeuter(1)

#
# Runtime error in ../../src/runtime/runtime-typedarray.cc, line 52
#
# args[0]->IsJSArrayBuffer()   

==== C stack trace ===============================

 1: 0xf70ab5
 2: 0xadeebf
 3: 0xadedd4
 4: 0x2ef17630693b
(d8):1: illegal access
%ArrayBufferNeuter(1)
^

d8>
```

Also give the other 'illegal access' case (a special SyntaxError type) a more
descriptive error message for its sole usage.

R=adamk
==========

to

==========
Make RUNTIME_ASSERT have more useful output in debug mode

Runtime asserts are were previously a bit annoying to debug, due to
the lack of a useful error message, even in debug mode. This patch
prints out some more information in debug mode for runtime assert
failures while preserving their exception-throwing semantics. While
we're at it, it requires a semicolon after RUNTIME_ASSERT macro
invocations.

```
$ rlwrap out/Debug/d8 --allow-natives-syntax
V8 version 5.1.0 (candidate)
d8> %ArrayBufferNeuter(1)

#
# Runtime error in ../../src/runtime/runtime-typedarray.cc, line 52
#
# args[0]->IsJSArrayBuffer()

==== C stack trace ===============================

 1: 0xf70ab5
 2: 0xadeebf
 3: 0xadedd4
 4: 0x2ef17630693b
(d8):1: illegal access
%ArrayBufferNeuter(1)
^

d8>
```

Also give the other 'illegal access' case (a special SyntaxError type) a more
descriptive error message for its sole usage.

R=adamk

Committed: https://crrev.com/78d845308fd89e2acdeb95ab01a20042794f04f1
Cr-Commit-Position: refs/heads/master@{#34401}
==========

[commit-bot: I haz the power, 2016-03-01 17:22:36]

Patchset 2 (id:??) landed as
https://crrev.com/78d845308fd89e2acdeb95ab01a20042794f04f1
Cr-Commit-Position: refs/heads/master@{#34401}