Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1748163006: Don't load GDI+ if GDI is disabled. (Closed)

Created:
4 years, 9 months ago by forshaw
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't load GDI+ if GDI is disabled. This is to fix an issue when win32k lockdown is enabled on PDF content which can cause application crashes. If GDI is disabled then there's little benefit to loading the GDI+ library. BUG=583038 Patch by forshaw@ R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/75e1a495ecb89461b3a3af2eb084112d9caac2e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M core/src/fxge/win32/fx_win32_device.cpp View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
forshaw
PTAL
4 years, 9 months ago (2016-03-03 00:24:54 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-03 00:27:33 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-03 01:40:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75e1a495ecb89461b3a3af2eb084112d9caac2e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698